Skip to content

C#: Cache Call::getArgumentForParameter()#960

Merged
calumgrant merged 1 commit into
github:masterfrom
hvitved:csharp/cache-get-arg
Feb 22, 2019
Merged

C#: Cache Call::getArgumentForParameter()#960
calumgrant merged 1 commit into
github:masterfrom
hvitved:csharp/cache-get-arg

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Feb 21, 2019

This predicate can take quite a while to compute on large snapshots, so cache it.

@hvitved hvitved added the C# label Feb 21, 2019
@hvitved hvitved requested a review from calumgrant February 21, 2019 10:43
@hvitved hvitved requested a review from a team as a code owner February 21, 2019 10:43
calumgrant
calumgrant approved these changes Feb 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@calumgrant calumgrant merged commit 1386af4 into github:master Feb 22, 2019
@hvitved hvitved deleted the csharp/cache-get-arg branch February 22, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @calumgrant